Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: detect & log signed queries via eth_call #618

Merged
merged 1 commit into from
Dec 20, 2024
Merged

feat: detect & log signed queries via eth_call #618

merged 1 commit into from
Dec 20, 2024

Conversation

CedarMist
Copy link
Member

@CedarMist CedarMist commented Sep 17, 2024 •
edited by ptrus
Loading

Fixes: #604

Adds oasis_web3_gateway_signed_queries prometheus counter.

@CedarMist CedarMist force-pushed the CedarMist/track-encrypted-view-calls branch from 197d119 to 692b0d4 Compare September 17, 2024 10:26
@CedarMist CedarMist self-assigned this Sep 17, 2024
@CedarMist CedarMist added the enhancement New feature or request label Sep 17, 2024
@CedarMist CedarMist marked this pull request as ready for review September 24, 2024 13:36
@ptrus
Copy link
Member

ptrus commented Oct 29, 2024

Do we want to get this merged?

@ptrus ptrus force-pushed the CedarMist/track-encrypted-view-calls branch from 692b0d4 to 25d4b0e Compare December 20, 2024 07:39
matevz
matevz approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@matevz matevz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how significant is the performance hit of the extra unmarshalling.

@ptrus
Copy link
Member

ptrus commented Dec 20, 2024

I wonder how significant is the performance hit of the extra unmarshalling.

We talked and think it should be negligible. We also don't expect a lot of signed queries.

@ptrus ptrus merged commit c270f65 into main Dec 20, 2024
6 checks passed
@ptrus ptrus deleted the CedarMist/track-encrypted-view-calls branch December 20, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrus ptrus ptrus approved these changes

@matevz matevz matevz approved these changes

@kostko kostko Awaiting requested review from kostko kostko is a code owner

Assignees

@CedarMist CedarMist

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track how many times signed queries are being used as a metric for graphana
3 participants
@CedarMist @ptrus @matevz