Improve numeric precision in reclaim escrow #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaw3d
requested review from
pro-wh,
peterjgilbert,
kostko and
tjanez
as code owners
buberdds
approved these changes
Aug 5, 2022
kostko
approved these changes
Aug 5, 2022
pro-wh
reviewed
Aug 5, 2022
src/popup/pages/Send/index.js
Outdated
| @@ -906,9 +906,9 @@ class SendPage extends React.Component { | |||
| if(!isNumber(inputAmount) || !new BigNumber(inputAmount).gt(0)){ | |||
| return 0 | |||
| } | |||
| const {amount ,shares} = this.props.nodeDetail | |||
| const {amount, shares} = this.props.nodeDetail | |||
| let sharePerAmount = new BigNumber(shares).dividedBy(amount).toString() | |||
There was a problem hiding this comment.
what precision does this division use?
There was a problem hiding this comment.
It defaults to 20 decimal places https://mikemcl.github.io/bignumber.js/#decimal-places
Good that you brought it up, BigNumber(inputAmount).multipliedBy(shares).dividedBy(amount) would be better
src/popup/pages/Send/index.js
Outdated
| let sharePerAmount = new BigNumber(shares).dividedBy(amount).toString() | ||
| let realShare = new BigNumber(inputAmount).multipliedBy(sharePerAmount).toFixed(4,1).toString() | ||
| let realShare = new BigNumber(inputAmount).multipliedBy(sharePerAmount).toFixed(cointypes.decimals, BigNumber.ROUND_DOWN) |
There was a problem hiding this comment.
here's one place we might not have to use ROUND_DOWN
lukaw3d
force-pushed
the
lw/reclaim-precision
branch
from
1605893 to
ffa00c2
Compare
lukaw3d
force-pushed
the
lw/reclaim-precision
branch
from
ffa00c2 to
c934260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change reclaiming with ALL button, but still related to #165 and #153