Merge pull request #288 from oasisprotocol/lw/dont-store-sensitive

Prevent browsers from writing sensitive form inputs to user data

CHANGELOG.md

@@ -1,5 +1,23 @@
 # Change Log
 
+## 1.8.1
+
+Spotlight change:
+
+- Prevent browsers from writing sensitive form inputs to user data
+  ([#288](https://github.com/oasisprotocol/oasis-wallet-ext/pull/288)).
+
+Little things:
+
+- Start polling for sapphire transaction statuses
+  ([#285](https://github.com/oasisprotocol/oasis-wallet-ext/pull/285)).
+
+Internal:
+
+- Update links in README
+  ([#286](https://github.com/oasisprotocol/oasis-wallet-ext/pull/286),
+  [#287](https://github.com/oasisprotocol/oasis-wallet-ext/pull/287)).
+
 ## 1.8.0
 
 Spotlight change:

package.json

@@ -1,6 +1,6 @@
 {
   "name": "oasis-wallet",
-  "version": "1.8.0",
+  "version": "1.8.1",
   "private": true,
   "scripts": {
     "build": "webpack --mode production",

public/manifest.json

@@ -3,7 +3,7 @@
   "short_name": "__MSG_appName__",
   "description": "__MSG_appDescription__",
   "manifest_version": 2,
-  "version": "1.8.0",
+  "version": "1.8.1",
   "default_locale": "en",
   "icons": {
     "16": "img/oasis.png",

src/popup/component/SecurityPwd/index.js

@@ -105,7 +105,7 @@ export default class SecurityPwd extends React.Component {
   }
   render() {
     return (
-      <form onSubmit={this.onSubmit}>
+      <form onSubmit={this.onSubmit} autoComplete="off">
           <div className={'common-container'}>
             {this.renderInput()}
           </div>

src/popup/component/TextInput/index.js

@@ -95,6 +95,7 @@ export default class TextInput extends Component {
                         spellCheck={false}
                         onFocus={this.onFocus}
                         onBlur={this.onBlur}
+                        autoComplete="off"
                     />
                     <img className="pwd-show-status click-cursor" onClick={this.onClickEye} src={imgSrc}></img>
                 </div>

src/popup/pages/CreatePassword/index.js

@@ -143,7 +143,7 @@ class CreatePassword extends React.Component {
       <CustomView
         propsClassName={"create-route-container"}
         history={this.props.history}>
-        <form onSubmit={this.onSubmit}>
+        <form onSubmit={this.onSubmit} autoComplete="off">
           <div className={"common-container"}>
             <p className={'desc-title'}>{getLanguage('createPassword')}</p>
             <div className="create_container">

src/popup/pages/ImportAccount/index.js

@@ -98,7 +98,9 @@ class ImportAccount extends React.Component {
           className={"text-area-input"}
           placeholder={getLanguage('inputPrivateKey')}
           value={this.state.privateKey}
-          onChange={this.handleTextareaChange} />
+          onChange={this.handleTextareaChange}
+          autoComplete="off"
+        />
       </div>
     )
   }
@@ -124,15 +126,20 @@ class ImportAccount extends React.Component {
       <p className={"import-title"}>{content}</p>
     </div>)
   }
+  onSubmit = (event) => {
+    event.preventDefault();
+  }
   render() {
     return (
       <CustomView
         title={getLanguage('importAccount_1')}
         history={this.props.history}>
-        <div className="import-account-container">
-          {this.renderInput()}
-        </div>
-        {this.renderBottom()}
+        <form onSubmit={this.onSubmit} autoComplete="off">
+          <div className="import-account-container">
+            {this.renderInput()}
+          </div>
+          {this.renderBottom()}
+        </form>
       </CustomView>
     )
   }

src/popup/pages/Lock/index.js

@@ -92,7 +92,7 @@ class LockPage extends React.Component {
     }
     renderPwdInput = () => {
         return (
-            <form onSubmit={this.onSubmit}>
+            <form onSubmit={this.onSubmit} autoComplete="off">
                 <div className={"lock-inner-container"}>
                     {this.renderWelcome()}
                     <TextInput

src/popup/pages/ResetPassword/index.js

@@ -183,10 +183,12 @@ class Reset extends React.Component {
             <CustomView
                 title={getLanguage('changeSecPassword')}
                 history={this.props.history}>
-                <div className="reset_container">
-                    {this.renderPasswordContent()}
-                </div>
-                {this.renderBottomBtn()}
+                <form onSubmit={this.onSubmit} autoComplete="off">
+                    <div className="reset_container">
+                        {this.renderPasswordContent()}
+                    </div>
+                    {this.renderBottomBtn()}
+                </form>
             </CustomView>
         )
     }

src/popup/pages/RestoreAccount/index.js

@@ -89,7 +89,9 @@ class RestoreAccount extends React.Component {
       <textarea
         className={"text-area-input"}
         value={this.state.privateKey}
-        onChange={this.onMneInput} />
+        onChange={this.onMneInput}
+        autoComplete="off"
+      />
     )
   }
   renderBottom = () => {
@@ -103,17 +105,23 @@ class RestoreAccount extends React.Component {
       </div>
     )
   }
+  onSubmit = (event) => {
+    event.preventDefault();
+  }
   render() {
     return (
       <CustomView
         propsClassName={"create-route-container"}
-        history={this.props.history}>
-        <div className="import-container">
-          <p className={'desc-title'}>{getLanguage('restoreWallet')}</p>
-          <p className={"import-title"}>{getLanguage("inputSeed")}</p>
-          {this.renderInput()}
-        </div>
-        {this.renderBottom()}
+        history={this.props.history}
+      >
+        <form onSubmit={this.onSubmit} autoComplete="off">
+          <div className="import-container">
+            <p className={'desc-title'}>{getLanguage('restoreWallet')}</p>
+            <p className={"import-title"}>{getLanguage("inputSeed")}</p>
+            {this.renderInput()}
+          </div>
+          {this.renderBottom()}
+        </form>
       </CustomView>
     )
   }