CORE: remove undefined from url

oacore · Nov 27, 2024 · 0a1e4a4 · 0a1e4a4
1 parent be742c9
commit 0a1e4a4
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/templates/search/results.jsx b/templates/search/results.jsx
@@ -35,8 +35,10 @@ const Results = ({ works, searchId }) =>
         memberType?.billing_type === 'supporting' ||
         memberType?.billing_type === 'sustaining'
 
-      const generateMetadataLink = (baseLink, propSearchId, propId) =>
-        `${baseLink}/?t=${propSearchId}-${propId}`
+      const generateMetadataLink = (baseLink, propSearchId, propId) => {
+        if (!propSearchId) return baseLink
+        return `${baseLink}/?t=${propSearchId}-${propId}`
+      }
 
       const modifiedReaderLink = readerLink
         ?.replace(/(https:\/\/)(core\.ac\.uk)/, '$1api.$2')