-
Notifications
You must be signed in to change notification settings - Fork 286
Add --number-separator
CLI flag
#892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some things to keep in mind:
So, if
We could even take a number format like Excel does, |
You're right, my first implementation actually took a localization as an input, but I reverted in 7c6cbba when I found out that num_crate did not support floating numbers as it would have been misleading to users if the decimal character wasn't affected. I renamed it to |
@@ -49,7 +49,7 @@ expression: info | |||
"lastChange": "22 years ago", | |||
"contributors": 4, | |||
"repoUrl": "https://github.com/user/repo.git", | |||
"numberOfCommits": "4", | |||
"numberOfCommits": 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense for this value to be a usize
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense to me, too.
refers to #706
Impacted by the CLI flag: