fix: make hackney an optional dependency (0.15.7)#54
Merged
Conversation
Req is the default backend for both one-shot and streaming HTTP. Hackney
is only used when a consumer opts into Nous.HTTP.Backend.Hackney /
Nous.HTTP.StreamBackend.Hackney via NOUS_HTTP_BACKEND or app config.
Forcing {:hackney, "~> 4.0"} as a hard dep in 0.15.x broke downstream
apps that pulled in any transitive optional constraint of hackney ~> 1.x
(e.g. aws ~> 1.0's optional hackney dep). Once hackney 4 entered the
graph, Mix activated the optional ~> 1.20 constraint and version
resolution failed:
Because "the lock" depends on "aws 1.0.10" which depends on
"hackney ~> 1.20", "the lock" requires "hackney ~> 1.20".
And because "nous >= 0.15.0" depends on "hackney ~> 4.0",
"the lock" is incompatible with "nous >= 0.15.0".
Apps using the hackney backend now declare {:hackney, "~> 4.0"} in
their own mix.exs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Req is the default backend for both one-shot and streaming HTTP. Hackney is only used when a consumer opts into Nous.HTTP.Backend.Hackney / Nous.HTTP.StreamBackend.Hackney via NOUS_HTTP_BACKEND or app config.
Forcing {:hackney, "~> 4.0"} as a hard dep in 0.15.x broke downstream apps that pulled in any transitive optional constraint of hackney ~> 1.x (e.g. aws ~> 1.0's optional hackney dep). Once hackney 4 entered the graph, Mix activated the optional ~> 1.20 constraint and version resolution failed:
Because "the lock" depends on "aws 1.0.10" which depends on
"hackney ~> 1.20", "the lock" requires "hackney ~> 1.20".
And because "nous >= 0.15.0" depends on "hackney ~> 4.0",
"the lock" is incompatible with "nous >= 0.15.0".
Apps using the hackney backend now declare {:hackney, "~> 4.0"} in their own mix.exs.