Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICMP responses from the internal IP #190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ICMP responses from the internal IP #190

wants to merge 2 commits into from

Conversation

james-otten
Copy link
Collaborator

No description provided.

@bradyjoh bradyjoh self-requested a review February 21, 2025 06:42
@bradyjoh bradyjoh self-assigned this Feb 21, 2025
bradyjoh
bradyjoh approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@bradyjoh bradyjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. What prompted you to make this addition?

Andrew-Dickinson
Andrew-Dickinson reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@Andrew-Dickinson Andrew-Dickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to troubleshoot a connectivity issue and ping 10.10.10.10 is a common troubleshooting step. I was confused why it didn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew-Dickinson Andrew-Dickinson Andrew-Dickinson approved these changes

@bradyjoh bradyjoh bradyjoh approved these changes

Assignees

@bradyjoh bradyjoh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james-otten @Andrew-Dickinson @bradyjoh