Fix: Installs whose number has been re-used as an NN shouldn't be able to get an NN of their own #802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where after an old install number is recycled as a network number for another node, that old install number is still able to get an NN of its own. This is needlessly confusing and creates extra edge cases when trying to disambiguate a number that is presented into a NN or Install Number. It's not a big deal to ask these folks to just fill out the join form again, so we disallow this from happening