Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Installs whose number has been re-used as an NN shouldn't be able to get an NN of their own #802

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Andrew-Dickinson
Copy link
Member

Fixes an issue where after an old install number is recycled as a network number for another node, that old install number is still able to get an NN of its own. This is needlessly confusing and creates extra edge cases when trying to disambiguate a number that is presented into a NN or Install Number. It's not a big deal to ask these folks to just fill out the join form again, so we disallow this from happening

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (c285614) to head (75aeb1d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #802   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files          89       89           
  Lines        3809     3811    +2     
=======================================
+ Hits         3614     3616    +2     
  Misses        195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant