Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ansible lint and make it happy #68

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

james-otten
Copy link
Collaborator

@james-otten james-otten commented Dec 25, 2024

  • Install collections from a new requirements.yml in the correct place. Has the side effect of pinning datadog.dd and cloud.terraform like we already did for k3s-ansible. Also makes that GH action a little cleaner.
  • Run ansible-lint on PRs
  • Make the linter happy
    • Rename various roles so their names contain _ not -
    • Remove some tailing whitespaces
    • Fix how templates and files are referenced
    • Set file perms for copied/templated files
    • Set names that start with capital letters
    • Line length
    • In one case, syntax (NODE_PORT)

Before merge:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants