TaskBar: Show xwayland mark even if name is not shown

[joezak11]

This makes more sense to me to allow xwayland mark to be shown when I don't need the window name

[nwg-piotr]

This way we have no tooltip_text for X apps, if not settings["show-app-name"] . Please fix.

[nwg-piotr]

Setting tooltip text should not depend on not len(name) > 0 but on settings["show-app-name"].

            if settings["show-app-name"]:
               (...)
            else:
                self.set_tooltip_text(_name)

[joezak11]

Yes but if settings["show-app-name"] is true then len(name) > 0 is also true so it should work the same way as before

[nwg-piotr]

Just check if X11 apps have tooltips. They have not on my side.

[joezak11]

Oops, my bad when xwayland mark is added to name it doesn't show tooltip

[nwg-piotr]

You do need to test your code before submission. It still doesn't work as it should.

If I understand well, you want the label to show up regardless of the "show-app-name" value, if the app has no app_id (runs on XWayland). IMO the simplest way to achieve this result is:

        if con.name:
            check_key(settings, "show-app-name", True)
            check_key(settings, "name-max-len", 20)

            name = con.name[:settings["name-max-len"]] if len(con.name) > settings["name-max-len"] else con.name
            if settings["mark-xwayland"] and not con.app_id:
                name = "X|" + name

            label = Gtk.Label()
            if settings["show-app-name"]:
                label.set_text(name)
            else:
                self.set_tooltip_text(name)
                if not con.app_id:
                    label.set_text("X")

            label.set_angle(settings["angle"])
            if settings["show-app-name"] or (settings["mark-xwayland"] and not con.app_id):
                self.box.pack_start(label, False, False, 0)