Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert unneeded check #119

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

t-boiko
Copy link
Contributor

@t-boiko t-boiko commented Dec 2, 2024

The checks are redundant because the maximum possible value after the loop ends is datasizeN - N, loop step is N (I introduced them in a previous commit). Only the SVE-based code's change from the previous commit is required (left it)

@t-boiko t-boiko force-pushed the revert_unneeded_check branch from 0fec145 to a71cf34 Compare December 4, 2024 15:45
Copy link
Contributor

@zlatinski zlatinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zlatinski zlatinski merged commit 4c439a8 into nvpro-samples:main Dec 4, 2024
1 check failed
@t-boiko t-boiko deleted the revert_unneeded_check branch December 4, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants