Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(systemverilog): Add SV textobjects #678

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

henrykvdb
Copy link
Contributor

Added very basic textobjects for SystemVerilog. Tested them in nvim also and they seemed to work fine :)

This is the first time I am writing treesitter querries so any critique is welcome!
(I ran the querry formatter so that should be okay)

@henrykvdb henrykvdb marked this pull request as draft September 15, 2024 16:05
@henrykvdb
Copy link
Contributor Author

I fixed some small issue and now everything behaves as expected.

This PR is linked to nvim-treesitter/nvim-treesitter#7170 and should be accepted at the same time ideally.

@henrykvdb henrykvdb marked this pull request as ready for review September 21, 2024 19:18
@clason clason requested a review from ribru17 October 15, 2024 07:23
Copy link
Member

@ribru17 ribru17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One nit: would you mind changing the @_start @_end double captures to just @_start? make-range knows to ignore the range if @_end is nil

@henrykvdb
Copy link
Contributor Author

henrykvdb commented Oct 15, 2024

Hi @ribru17 thank you for the review.

I don't have a setup ready to quickly re-test the proposed changes and I am not comfortable doing it without testing, however feel free to modify my PR as you like

@clason clason merged commit 5d6069b into nvim-treesitter:master Oct 16, 2024
8 checks passed
@clason
Copy link
Collaborator

clason commented Oct 16, 2024

(#make-range! is slated for removal anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants