Fix previews (video, pdf) and support uppercase file extensions #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have just tried to setup this plugin in NeoVim.
First of all, thank you for keeping this plugin alive @Conni2461 and everyone else involved!
It seems there are a few problems with file previews in its current version (possibly partly related to the breaking change #35):
This PR is supposed to fix those things:
.png
when using the command option-png
(This is at least true for my installed version, 23.03.0 - this might need double checking for earlier versions). Therefore I have removed the additional.png
for the output file..JPG
or.MP4
, I get the error message:unknown file ..image_path.JPG
. I have added a line to make the extracted extension lowercase to match the following case patterns.@HendrikPetertje Could you verify if these changes still work for you?