Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: luarocks/rocks.nvim support #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrcjkb
Copy link

@mrcjkb mrcjkb commented May 23, 2024

Hey again 👋

This PR makes this plugin compatible with luarocks, and adds the luarocks-tag-release workflow, for automatically publishing tagged releases.

See also: nvim-telescope/telescope.nvim#2276

@Conni2461 I see this plugin doesn't have any semver tags.
Not sure if you are willing to start maintaining them (manually or automated)?
An alternative would be to just upload the scm rockspec (but that would take away the ability to pin installations).

I've tested this locally with the scm rockspec (luarocks make).

@mrcjkb
Copy link
Author

mrcjkb commented Jul 21, 2024

@Conni2461 do you have any interest in this?
Otherwise, I could move it to the NURR. But that would require patching the fzf_lib module.

@Conni2461
Copy link
Member

I am interested, i can review this in 2 weeks

@Pakrohk
Copy link

Pakrohk commented Aug 8, 2024

I am trying to install your plugin while using rocks, what is the installation path?

@mrcjkb
Copy link
Author

mrcjkb commented Sep 24, 2024

@Conni2461 any update on this? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants