-
Notifications
You must be signed in to change notification settings - Fork 763
feat(Timeline): new component #4215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
β¦into feat/popover-anchor
β¦ine-component
@J-Michalek I've made a few changes, let me know what you think! Basically I updated the design, removed unnecessary divs, used Avatar component for the indicator since it supports We can start the docs if it's ok right after π |
commit: |
@benjamincanac Looks great! Good job on cleaning it up. For the docs I think we can take inspiration from Stepper omitting the disabled part: https://ui.nuxt.com/components/stepper#disabled As for the example section, we should do https://ui.nuxt.com/components/stepper#control-active-item and https://ui.nuxt.com/components/stepper#with-custom-slot I also think an example for something more complex like this #814 (comment) or #814 (comment) would be great. Can I start on the docs or would you like to take it from here? |
Sure! As you wish, just let me know if you want me to do it π |
Alright I will get started on it. |
I've updated the design a bit again to support all sizes from the Avatar component. I experimented to reproduce Origin UI basic design, here's the config needed: <UTimeline size="3xs" color="neutral" :ui="{ indicator: 'bg-default ring-2 ring-inset ring-accented group-data-[state=completed]:ring-inverted group-data-[state=completed]:bg-default group-data-[state=active]:ring-inverted group-data-[state=active]:bg-default' }" /> |
Wow loving these! Will get to the docs tomorrow. |
@benjamincanac I've added the docs but it definitely needs some finishing touches. Please check the texts and headings as I was not too sure about how I should call them properly. Perhaps the example is a little too long but I'll leave it to your judgement: I have also taken the examples you have provided here including the one with my avatar, just a heads up that its there (I don't mind if you don't). |
Thanks! I'll finish this up in the next days then. Haha don't worry I made the example with your avatar on purpose since you made the PR π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @J-Michalek! π
π Linked issue
Resolves: #814
β Type of change
π Description
I've added the Timeline component. Can be used to display the current progress of several steps.
π Checklist