Skip to content

feat(NavigationMenu): add option to render UChip on item when colla… #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: v3
Choose a base branch
from
Open

feat(NavigationMenu): add option to render UChip on item when colla… #4213

wants to merge 4 commits into from

Conversation

HugoRCD
Copy link
Member

@HugoRCD HugoRCD commented May 23, 2025

🔗 Linked issue

Resolves https://github.com/nuxt/ui-pro/issues/1058#issuecomment-2897441099

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@HugoRCD HugoRCD self-assigned this May 23, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 23, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@4213

commit: aa16084

@nuxthub-admin NuxtHub Admin
Copy link
Contributor

nuxthub-admin bot commented May 23, 2025 •
edited
Loading

✅ Deployed ui3

Deployed ui3 aa16084 to preview

🔗 feat-1058.ui-6q2.pages.dev
📌 a0482281.ui-6q2.pages.dev
📱
View QR Code QR code linking to deployment URL.

📋 View deployment logs

@maximepvrt
Copy link
Contributor

@HugoRCD Would it be possible to generalize it everywhere ? linked issue : #3827

@HugoRCD
Copy link
Member Author

HugoRCD commented May 23, 2025

@HugoRCD Would it be possible to generalize it everywhere ? linked issue : #3827

I'll try to integrate this properly into the NavigationMenu because the component is starting to get a bit complicated 😅 But yes I'll try to see too!

@HugoRCD HugoRCD marked this pull request as ready for review May 26, 2025 08:23
benjamincanac
benjamincanac reviewed May 26, 2025
View reviewed changes
@benjamincanac
Copy link
Member

Maybe we could just use the item.badge field when collapsed instead of introducing a new one? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac left review comments

Assignees

@HugoRCD HugoRCD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HugoRCD @maximepvrt @benjamincanac