Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#518): Adds auth token to fetch req #537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tkjaergaard
Copy link
Contributor

@tkjaergaard tkjaergaard commented Oct 24, 2024

πŸ”— Linked issue

resolves #518

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)

πŸ“š Description

This PR adresses a bug where the fetch request dosen't take the authToken of the found registry into account. This fix will use the .npmrc(s) to first find the registry and then search for an associated authToken.

Unfortunately npm.pkg.github.com dosen't support fetching a specific version like the NPM registry like: /<pkgName>/latest. So i we-wrote to use the /<pkgName> endpoint and then find the desired version meta data.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d032c67). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/commands/module/add.ts 0.00% 48 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main    #537   +/-   ##
======================================
  Coverage        ?   1.29%           
======================================
  Files           ?      44           
  Lines           ?    2853           
  Branches        ?      44           
======================================
  Hits            ?      37           
  Misses          ?    2774           
  Partials        ?      42           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxi add command not working with private repositories where auth is required
2 participants