-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add env-flag for env-specific config (#357) #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Till Sanders <[email protected]>
Signed-off-by: Till Sanders <[email protected]>
Does this PR also apply for the environment overrides set in export default defineNuxtConfig({
$production: {
ignore: ['app/pages/dev'],
scripts: {
registry: {
cloudflareWebAnalytics: true,
},
},
},
$preview: {
ignore: ['app/pages/dev'],
},
}); |
pi0
reviewed
Aug 23, 2024
Signed-off-by: Till Sanders <[email protected]>
tillsanders
added a commit
to tillsanders/nuxt
that referenced
this pull request
Sep 10, 2024
Documentation accompanying the PR for Nuxt CLI: nuxt/cli#424 (currently in review)
I added a commit to address the feedback above. Is there anything else I can do to improve this pull request? |
pi0
reviewed
Oct 7, 2024
pi0
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than usage, looks good to me
Co-authored-by: Pooya Parsa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is proposing to add a new
--env [name]
attribute to Nuxi. The attribute will be passed to theenvName
option of the c12 library. This adds the ability to support environment overrides (environment-specific configuration) for custom environments. Currently, c12 supports that and the types of the nuxt configuration file are aware of that, but there is no way to actually use custom environments, becauseNODE_ENV
cannot be set to values other thanproduction
ordevelopment
. This PR closes the gap, making deployments to different environments easier.See #357.
Should this be approved, I would be happy to amend the documentation accordingly.