Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev,preview): correctly apply --dotenv arg #381

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix(dev,preview): correctly apply --dotenv arg #381

wants to merge 4 commits into from

Conversation

DamianGlowala
Copy link
Member

resolves #360

This corrects types for the --dotenv flag and sets the default value at source.

@DamianGlowala DamianGlowala mentioned this pull request Mar 30, 2024
Open
8 tasks
@DamianGlowala DamianGlowala requested a review from pi0 April 2, 2024 08:18
danielroe
danielroe reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will running npx nuxi preview --dotenv continue to work as expected (ie. a non-breaking change)?

@DamianGlowala DamianGlowala changed the title fix(dev): correctly apply --dotenv arg fix(dev,preview): correctly apply --dotenv arg May 10, 2024
@DamianGlowala DamianGlowala marked this pull request as draft May 10, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nuxt reads a different env file if value is not found in the configured env file
2 participants
@DamianGlowala @danielroe