Skip to content

Conversation

dreyfus92
Copy link

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Replace consola's bundled clack with latest @clack/prompts alpha
  • Add styled box for final success message with green border
  • Improve dependency installation spinner with proper success/error handling
  • Update build configs to externalize clack dependencies

@dreyfus92 dreyfus92 requested a review from danielroe as a code owner October 8, 2025 01:26
Copy link
Contributor

github-actions bot commented Oct 8, 2025

πŸ“¦ Bundle Size Comparison

πŸ“ˆ nuxi

Metric Base Head Diff
Rendered 5079.11 KB 5097.25 KB +18.14 KB (+0.36%)

πŸ“ˆ nuxt-cli

Metric Base Head Diff
Rendered 108.86 KB 109.20 KB +0.34 KB (+0.31%)

πŸ“ˆ create-nuxt

Metric Base Head Diff
Rendered 2178.73 KB 2197.07 KB +18.35 KB (+0.84%)

Copy link

pkg-pr-new bot commented Oct 8, 2025

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@1077
npm i https://pkg.pr.new/nuxi@1077
npm i https://pkg.pr.new/@nuxt/cli@1077

commit: cee54dd

Copy link

codspeed-hq bot commented Oct 8, 2025

CodSpeed Performance Report

Merging #1077 will not alter performance

Comparing dreyfus92:feat/add-box-to-init (cee54dd) with main (d8e89aa)

Summary

βœ… 2 untouched

@danielroe danielroe changed the title feat: enhance nuxi init with clack box styling and improved spinners feat(init): use clack for box styling and improved spinners Oct 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@4509643). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/commands/init.ts 0.00% 17 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1077   +/-   ##
=======================================
  Coverage        ?   25.28%           
=======================================
  Files           ?       81           
  Lines           ?     4529           
  Branches        ?      238           
=======================================
  Hits            ?     1145           
  Misses          ?     3352           
  Partials        ?       32           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe
Copy link
Member

I love it!

SCR-20251008-fquj

we might choose green rather than blue to go with the nuxt styling...

and what do you think about the terminal output from the install command - should it be either hidden if successful (?) or offset from the 'status'?

@dreyfus92
Copy link
Author

dreyfus92 commented Oct 8, 2025

we might choose green rather than blue to go with the nuxt styling...

I left it blue cause i believe that was the original color that it had, or at least that's what i saw from the shared sc from james

and what do you think about the terminal output from the install command - should it be either hidden if successful (?) or offset from the 'status'?

i think that's a matter of preference, personally i would leave it as it is. @43081j what do you think about this one?

@43081j
Copy link
Contributor

43081j commented Oct 12, 2025

i would probably hide the output if it succeeds (which is an option of tasklog)

successful runs probably dont need the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants