Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transpile unhead even when meta: false is set #877

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Aug 8, 2023

πŸ”— Linked issue

Fixes: #876

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This occurs due to the effect of changing the defineNuxtComponent to use useHead at #838.

Now it is only transpiled if meta: other than false, so meta: false will result in a build error.
I think that to enable bridge.head, bridge.app also needs to be enabled, so I moved it into setupAppBridge.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe changed the title fix: need to transpile unhead even if meta is false fix: transpile unhead even when meta: false is set Aug 9, 2023
@danielroe danielroe merged commit e1c033e into nuxt:main Aug 9, 2023
9 checks passed
@danielroe danielroe mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error with 3.0.0-28177393.984ce7c
2 participants