perf(nuxt): unsubscribe from asyncData watch when unmounting (#1185)

Co-authored-by: drodichkin <[email protected]>
nuxt · Apr 17, 2024 · ac45690 · ac45690
1 parent c1ea816
commit ac45690
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/bridge/src/runtime/composables/asyncData.ts b/packages/bridge/src/runtime/composables/asyncData.ts
@@ -299,7 +299,9 @@ export function useAsyncData<
     const hasScope = getCurrentScope()
     if (options.watch) {
       const unsub = watch(options.watch, () => asyncData.refresh())
-      if (hasScope) {
+      if (instance) {
+        onUnmounted(unsub)
+      } else if (hasScope) {
         onScopeDispose(unsub)
       }
     }
@@ -308,7 +310,9 @@ export function useAsyncData<
         return asyncData.refresh()
       }
     })
-    if (hasScope) {
+    if (instance) {
+      onUnmounted(off)
+    } else if (hasScope) {
       onScopeDispose(off)
     }
   }