Skip to content

fix: prefer nitro.static over _generate #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2025
Merged

fix: prefer nitro.static over _generate #774

merged 2 commits into from
Jun 15, 2025

Conversation

danielroe
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Since nuxi v3.8, we've supported setting nuxt.options.nitro.static instead of nuxt.options._generate (which is an internal flag) - see nuxt/nuxt#21860.

Now, in preparation for Nuxt v4, we've removed the types for _generate (see nuxt/nuxt#32355). This PR adds support for new version in backwards compatible way (ignoring type issues) - I'd suggest you remove support in a future major.

Copy link

netlify bot commented Jun 11, 2025

βœ… Deploy Preview for friendly-lamington-fb5690 ready!

Name Link
πŸ”¨ Latest commit 642e2e0
πŸ” Latest deploy log https://app.netlify.com/projects/friendly-lamington-fb5690/deploys/684a606412ff3c000861954e
😎 Deploy Preview https://deploy-preview-774--friendly-lamington-fb5690.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.34%. Comparing base (1b72db3) to head (642e2e0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
+ Coverage   46.19%   46.34%   +0.14%     
==========================================
  Files          11       11              
  Lines         671      671              
  Branches       37       37              
==========================================
+ Hits          310      311       +1     
+ Misses        361      360       -1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe merged commit 7c7c525 into main Jun 15, 2025
8 of 9 checks passed
@danielroe danielroe deleted the generate-static branch June 15, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant