feat: load app name from capacitor.config.{json,js,ts}
#469
+22
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of right now, the app name for the to-be-generated
ionic.config.json
is derived from the localpackage.json
. This results in the followingappName
:But the official Ionic configuration recommends:
I believe a better approach is to use any of the existing Capacitor configs, as it includes the to be published app name:
capacitor.config.json
capacitor.config.ts
Since a valid
name
for apackage.json
isn't allowed to include uppercase letters, the Capacitor config holds the more appropriate app name.