Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDROVE-2983: Bump the version number to 5.5.2 #5531

Merged

Conversation

gitofanindya
Copy link
Collaborator

@gitofanindya gitofanindya commented Jan 3, 2025

Summary by Sourcery

Bump the version to 5.5.2 and update the changelog.

Documentation:

  • Add a changelog for version 5.5.2.

Chores:

  • Update the version number to 5.5.2.

Copy link
Contributor

sourcery-ai bot commented Jan 3, 2025

Reviewer's Guide by Sourcery

This pull request bumps the version number to 5.5.2 and updates the changelog.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Bumped version to 5.5.2
  • Changed version number from 5.5.1 to 5.5.2 in nxdrive/__init__.py
nxdrive/__init__.py
Updated changelog
  • Added a new changelog entry for version 5.5.2
  • Added a new file docs/changes/5.5.2.md with the changelog entry
docs/changes.md
docs/changes/5.5.2.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gitofanindya - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The changes.md file has incorrect links - both 5.5.1 and 5.5.2 are pointing to 5.5.0.md and have the same diff link. Please update these to point to the correct changelog files and diffs.
  • The changelog file for 5.5.2 is empty with placeholder JIRA references. If this PR is ready for merge, please fill in the actual changelog entries.
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

docs/changes.md Outdated
@@ -23,6 +23,7 @@
- [5.4.1](changes/5.4.1.md) ([diff](https://github.com/nuxeo/nuxeo-drive/compare/release-5.4.0...release-5.4.1))
- [5.5.0](changes/5.5.0.md) ([diff](https://github.com/nuxeo/nuxeo-drive/compare/release-5.4.1...release-5.5.0))
- [5.5.1](changes/5.5.0.md) ([diff](https://github.com/nuxeo/nuxeo-drive/compare/release-5.5.0...master))
- [5.5.2](changes/5.5.0.md) ([diff](https://github.com/nuxeo/nuxeo-drive/compare/release-5.5.0...master))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Incorrect link for 5.5.2

The link for 5.5.2 is identical to 5.5.1 and points to master. It should point to the comparison between 5.5.1 and 5.5.2. Please update with the correct comparison URL.


## Core

- [NXDRIVE-2](https://jira.nuxeo.com/browse/NXDRIVE-2):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Repeated JIRA ticket

All entries point to the same JIRA ticket, NXDRIVE-2. Please verify that these are the correct tickets for each change.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.08%. Comparing base (74fc14e) to head (bc618f6).
Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5531      +/-   ##
==========================================
+ Coverage   49.24%   52.08%   +2.84%     
==========================================
  Files          94       96       +2     
  Lines       15699    16094     +395     
==========================================
+ Hits         7731     8383     +652     
+ Misses       7968     7711     -257     
Flag Coverage Δ
functional 42.88% <100.00%> (+4.80%) ⬆️
integration 2.01% <ø> (-0.06%) ⬇️
unit 40.51% <100.00%> (+2.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/changes/5.5.2.md Outdated Show resolved Hide resolved
nxdrive/__init__.py Show resolved Hide resolved
@gitofanindya gitofanindya merged commit e57e0ab into master Jan 6, 2025
21 checks passed
@gitofanindya gitofanindya deleted the wip-NXDRIVE-2983-wip-NXDRIVE-2946-post-release-5.5.1 branch January 6, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants