-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXDROVE-2983: Bump the version number to 5.5.2 #5531
NXDROVE-2983: Bump the version number to 5.5.2 #5531
Conversation
Reviewer's Guide by SourceryThis pull request bumps the version number to 5.5.2 and updates the changelog. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gitofanindya - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changes.md file has incorrect links - both 5.5.1 and 5.5.2 are pointing to 5.5.0.md and have the same diff link. Please update these to point to the correct changelog files and diffs.
- The changelog file for 5.5.2 is empty with placeholder JIRA references. If this PR is ready for merge, please fill in the actual changelog entries.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
docs/changes.md
Outdated
@@ -23,6 +23,7 @@ | |||
- [5.4.1](changes/5.4.1.md) ([diff](https://github.com/nuxeo/nuxeo-drive/compare/release-5.4.0...release-5.4.1)) | |||
- [5.5.0](changes/5.5.0.md) ([diff](https://github.com/nuxeo/nuxeo-drive/compare/release-5.4.1...release-5.5.0)) | |||
- [5.5.1](changes/5.5.0.md) ([diff](https://github.com/nuxeo/nuxeo-drive/compare/release-5.5.0...master)) | |||
- [5.5.2](changes/5.5.0.md) ([diff](https://github.com/nuxeo/nuxeo-drive/compare/release-5.5.0...master)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Incorrect link for 5.5.2
The link for 5.5.2 is identical to 5.5.1 and points to master
. It should point to the comparison between 5.5.1 and 5.5.2. Please update with the correct comparison URL.
|
||
## Core | ||
|
||
- [NXDRIVE-2](https://jira.nuxeo.com/browse/NXDRIVE-2): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Repeated JIRA ticket
All entries point to the same JIRA ticket, NXDRIVE-2. Please verify that these are the correct tickets for each change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5531 +/- ##
==========================================
+ Coverage 49.24% 52.08% +2.84%
==========================================
Files 94 96 +2
Lines 15699 16094 +395
==========================================
+ Hits 7731 8383 +652
+ Misses 7968 7711 -257
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Bump the version to 5.5.2 and update the changelog.
Documentation:
Chores: