@can directive improvements #2483

k0ka · 2023-12-10T14:43:44Z

Resolves #2453
Resolves #2225

Added or updated tests
Documented user facing changes
Updated CHANGELOG.md

Changes

Split up @can directive into @canFind, @canModel, @canQuery, @canResolved and @canRoot
Added action and return_value arguments to @can* family of directives
Allows using any objects in @can* family of directives

Breaking changes

The @can directive is deprecated and would be removed in the next major update.

spawnia

Thanks for starting this.

CHANGELOG.md

UPGRADE.md

docs/master/api-reference/directives.md

docs/master/security/authorization.md

src/Auth/CanResolvedDirective.php

tests/Integration/Auth/CanFindDirectiveDBTest.php

tests/Unit/Auth/CanDirectiveTestBase.php

tests/Unit/Auth/CanModelDirectiveTest.php

tests/Unit/Auth/CanRootDirectiveTest.php

Co-authored-by: Benedikt Franke <[email protected]>

@eq

- fixed "or :[]" in directives.md - fixed exception explanation in @canResolved - change @eq to @WhereKey in tests - add final to tests

- remove unused "query:true" arguments in CanQueryDirectiveDBTest

CHANGELOG.md

UPGRADE.md

docs/master/api-reference/directives.md

docs/master/security/authorization.md

src/Auth/CanResolvedDirective.php

tests/Integration/Auth/CanFindDirectiveDBTest.php

tests/Integration/Auth/CanResolvedDirectiveDBTest.php

tests/Unit/Auth/CanDirectiveTestBase.php

Co-authored-by: Benedikt Franke <[email protected]>

…find

…find

src/Auth/BaseCanDirective.php

src/Auth/CanResolvedDirective.php

spawnia · 2023-12-11T13:00:34Z

Thank you, released with https://github.com/nuwave/lighthouse/releases/tag/v6.27.0.

k0ka and others added 6 commits December 10, 2023 15:38

@can directive improvements

0eb4f13

Apply php-cs-fixer changes

383f798

add link to the PR

0162522

Normalize composer.json

bf62d47

remove "or :[CanArgs]"

46ecacb

fix typo

3982815

k0ka added the enhancement A feature or improvement label Dec 10, 2023

spawnia requested changes Dec 10, 2023

View reviewed changes

k0ka and others added 6 commits December 10, 2023 19:34

Apply suggestions from code review

5f5a411

Co-authored-by: Benedikt Franke <[email protected]>

- fixed CHANGELOG.md

d6e4062

- fixed "or :[]" in directives.md - fixed exception explanation in @canResolved - change @eq to @WhereKey in tests - add final to tests

- added diff block to UPGRADE.md

423b06d

- remove unused "query:true" arguments in CanQueryDirectiveDBTest

fix typo in exception

26e78df

Merge branch 'master' into can-improvement

83b6886

fix @canResolved documentation in authorization.md

d03f50e

spawnia reviewed Dec 11, 2023

View reviewed changes

k0ka and others added 8 commits December 11, 2023 11:18

Apply suggestions from code review

8d493a1

Co-authored-by: Benedikt Franke <[email protected]>

Update UPGRADE.md

0df66bd

Co-authored-by: Benedikt Franke <[email protected]>

return_value => returnValue

6346f87

combine test queries

8c10b5f

move Base types definition to another function and include it in @can…

364cb88

…find

make commonTypes() protected

4433731

Apply php-cs-fixer changes

41a7897

Merge branch 'master' into can-improvement

ba48271

spawnia reviewed Dec 11, 2023

View reviewed changes

src/Auth/BaseCanDirective.php Show resolved Hide resolved

src/Auth/CanResolvedDirective.php Outdated Show resolved Hide resolved

k0ka and others added 3 commits December 11, 2023 12:25

- added test for @canResolved to handle plain object

9af29ef

- added signatures for callables

6166e57

Apply php-cs-fixer changes

7995e32

spawnia merged commit e2092a9 into master Dec 11, 2023

spawnia deleted the can-improvement branch December 11, 2023 12:54

rocket-micha mentioned this pull request Feb 19, 2024

@canFind is missing "model" argument in graphql definition #2513

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@can directive improvements #2483

@can directive improvements #2483

k0ka commented Dec 10, 2023

spawnia left a comment

spawnia commented Dec 11, 2023

@can directive improvements #2483

@can directive improvements #2483

Conversation

k0ka commented Dec 10, 2023

spawnia left a comment

Choose a reason for hiding this comment

spawnia commented Dec 11, 2023