Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return empty results for pagination first: 0 #2480

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Return empty results for pagination first: 0 #2480

merged 7 commits into from
Dec 15, 2023

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Dec 5, 2023 •
edited
Loading

Resolves #2472

@jdjoshuadavison please review.

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

Returns empty results when pagination with first: 0 is requested.

Breaking changes

This is a behavioral change, but I consider it a bugfix.

@spawnia spawnia added the bug An error within Lighthouse label Dec 5, 2023
jdjoshuadavison
jdjoshuadavison approved these changes Dec 14, 2023
View reviewed changes
Copy link

@jdjoshuadavison jdjoshuadavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay and thank you for your work on this issue. I was able to get this version running in my project this morning and I'm happy that my tests were successful and requesting first: 0 behaved as expected.

jdjoshuadavison
jdjoshuadavison approved these changes Dec 14, 2023
View reviewed changes
Copy link

@jdjoshuadavison jdjoshuadavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay and thank you for your work on this issue. I was able to get this version running in my project this morning and I'm happy that my tests were successful and requesting first: 0 behaved as expected.

@spawnia spawnia merged commit e1b3660 into master Dec 15, 2023
@spawnia spawnia deleted the pagination-first-0 branch December 15, 2023 12:47
spawnia added a commit that referenced this pull request Dec 15, 2023
@spawnia
link #2480
a3962dc
@spawnia
Copy link
Collaborator Author

spawnia commented Dec 15, 2023

Released with https://github.com/nuwave/lighthouse/releases/tag/v6.29.0. Please consider sponsoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdjoshuadavison jdjoshuadavison jdjoshuadavison approved these changes

Assignees
No one assigned
Labels
bug An error within Lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination - passing first: 0 returns all results, bypassing defaultCount and maxCount
2 participants
@spawnia @jdjoshuadavison