Ensure @rule is never applied to argument lists themselves

nuwave · Dec 17, 2023 · 306be3f · 306be3f
1 parent a3962dc
commit 306be3f
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 6 deletions.
diff --git a/src/Validation/RulesGatherer.php b/src/Validation/RulesGatherer.php
@@ -60,12 +60,11 @@ protected function gatherRulesRecursively(ArgumentSet $argumentSet, array $argum
                 Utils::instanceofMatcher(ArgDirective::class),
             );
 
-            if (
-                $argument->type instanceof ListType
-                && is_array($argument->value)
-            ) {
-                foreach ($argument->value as $index => $value) {
-                    $this->handleArgumentValue($value, $directivesForArgument, array_merge($nestedPath, [$index]));
+            if ($argument->type instanceof ListType) {
+                if (is_array($argument->value)) {
+                    foreach ($argument->value as $index => $value) {
+                        $this->handleArgumentValue($value, $directivesForArgument, array_merge($nestedPath, [$index]));
+                    }
                 }
             } else {
                 $this->handleArgumentValue($argument->value, $directivesForArgument, $nestedPath);

diff --git a/tests/Integration/Validation/RulesDirectiveTest.php b/tests/Integration/Validation/RulesDirectiveTest.php
@@ -306,4 +306,54 @@ public static function invalidMessageArguments(): array
             [/** @lang GraphQL */ '[{rule: 3, message: "asfd"}]'],
         ];
     }
+
+    public function testValidateElementsOfListType(): void
+    {
+        $this->schema = /** @lang GraphQL */ '
+        type Query {
+            foo(
+                bar: [String]
+                @rules(
+                    apply: ["required"]
+                )
+            ): String
+        }
+        ';
+
+        $this
+            ->graphQL(/** @lang GraphQL */ '
+            {
+                foo(
+                    bar: ["", null, "bar"]
+                )
+            }
+            ')
+            ->assertGraphQLValidationKeys(['bar.0', 'bar.1']);
+
+        $this
+            ->graphQL(/** @lang GraphQL */ '
+            {
+                foo(
+                    bar: []
+                )
+            }
+            ')
+            ->assertJson([
+                'data' => [
+                    'foo' => Foo::THE_ANSWER,
+                ],
+            ]);
+
+        $this
+            ->graphQL(/** @lang GraphQL */ '
+            {
+                foo
+            }
+            ')
+            ->assertJson([
+                'data' => [
+                    'foo' => Foo::THE_ANSWER,
+                ],
+            ]);
+    }
 }