[Bug] fix(ntnx_subnets_v2): only run remove_empty_ip_config if ip_config isn’t empty #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig when ip_config key is empty
plugins/modules/ntnx_subnets_v2.py
Outdated
| subnets = get_subnet_api_instance(module) | ||
| current_spec = get_subnet(module, subnets, ext_id=ext_id) | ||
| remove_empty_ip_config(current_spec) | ||
| if current_spec.to_dict()['ip_config'] is not None: |
Collaborator
There was a problem hiding this comment.
nit: can we move this check inside remove_empty_ip_config.
Author
There was a problem hiding this comment.
abhinavbansal29
requested changes
Aug 5, 2025
| if empty_ipv6 and empty_ipv4: | ||
| ip_config.remove(item) | ||
| setattr(obj, "ip_config", ip_config) | ||
| if obj.to_dict()['ip_config'] is not None: |
Collaborator
There was a problem hiding this comment.
What will happen if ip_config is not present in obj?
| if empty_ipv6 and empty_ipv4: | ||
| ip_config.remove(item) | ||
| setattr(obj, "ip_config", ip_config) | ||
| if obj.to_dict()['ip_config'] is not None: |
Collaborator
There was a problem hiding this comment.
Suggested change
| if obj.to_dict()['ip_config'] is not None: | |
| ip_config = obj.to_dict().get("ip_config", []) | |
| if len(ip_config)!=0: |
| "$dataItemDiscriminator", | ||
| ] | ||
|
|
||
| ip_config = obj.to_dict().get("ip_config", []) |
Collaborator
There was a problem hiding this comment.
Please remove this, if you are using the above suggested change.
Collaborator
|
Hi @ntnx-cpranava , Can you please have a look to the mentioned comments? |
Collaborator
|
Hi @ntnx-cpranava , Can you please have a look to the above mentioned comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
On update_subnet() in ntnx_subnets_v2.py, previously remove_empty_ip_config(current_spec) was always invoked—even when current_spec.ip_config was None, which triggers errors when subnet does not IPAM features enabled. This commit ensures we only perform this clean‑up when ip_config actually exists.
Changes