Automation mssql #141
Open
Automation mssql #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g, and createSetupConfig
Merging with main
…ration to 'provisioning' file
manavrajvanshi
requested changes
Sep 11, 2023
Contributor
manavrajvanshi
left a comment
manavrajvanshi
left a comment
There was a problem hiding this comment.
Minor comments and a question:
Why do we have 2 pg - si tests? Can we combine those into one?
Also, what do you think about moving the files appConnectivity.go, provisioning.go and setup.go into a commons folder?
automation/provisioning.go
Outdated
|
|
||
| // Nil check | ||
| if st == nil || clientset == nil || v1alpha1ClientSet == nil { | ||
| errMsg := "Error: ProvisioningTestSetup() starting ended! " |
Contributor
There was a problem hiding this comment.
Can we use a better statement here instead of starting ended?
Perhaps something like nil parameters/arguments or initialization failed etc?
…paths, and added slight logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
How Has This Been Tested?:
-- app connectivity for MSSQL failing. This is not a code issue, rather a pod/image issue. I'm investigating this now.
pg-si_test.log
mssql_test.log