refactor: Stricter EKS kube-proxy mode in Go API #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
reviewed
Sep 29, 2025
dkoshkin
approved these changes
Sep 30, 2025
supershal
approved these changes
Oct 6, 2025
Contributor
supershal
left a comment
supershal
left a comment
There was a problem hiding this comment.
Great way to separate out without affecting the API.
Use Go types to restrict valid values rather than post-generation edits. This does not change the external schema for Kubernetes API clients, but provides stricter Go API semantics.
jimmidyson
force-pushed
the
jimmi/eks-kubeproxy-api
branch
from
5d2ab95 to
5693d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Use Go types to restrict valid values rather than post-generation edits. This does not change the external schema for Kubernetes API clients, but provides stricter Go API semantics.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: