Fix issue with some terminal that might not properly support kitty #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyProtocolGuard is initialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
On terminal like Alacritty, Rioterm and Ghostty that "kind of support" kitty protocol (but maybe not perfectly ?), the side-effect of
supports_keyboard_enhancementseems to cause some issues when some characters are printed on linux (cf. nushell/nushell#13570 (comment))Using
kitty_protocol_availableonly once when the struct is initialized would solve the issue and I think is a bit better to do.Alternative
use a a static
std::sync::Onceinstead ?