Skip to content

feat: events that only repaint the menu #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blindFS
Copy link
Contributor

@blindFS blindFS commented Mar 15, 2025

For menu events of #885 .

@blindFS
Copy link
Contributor Author

blindFS commented Mar 15, 2025

Need more test in different environments

@blindFS
Copy link
Contributor Author

blindFS commented Mar 15, 2025

Moving cursor around (left/right mostly) also triggers the repainting, prompt + parsing + highlighting.
I think that could also be optimized.

@ysthakur
Copy link
Member

@blindFS Is this ready to review?

@blindFS blindFS marked this pull request as draft June 21, 2025 20:21
@blindFS
Copy link
Contributor Author

blindFS commented Jun 21, 2025

@blindFS Is this ready to review?

It's too hacky and of low priority. I'd prefer an async solution for all events anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants