feat: immediately execute command #882
Conversation
| // If the `external_printer` feature is enabled, we need to | ||
| // periodically yield so that external printers get a chance to | ||
| // print. Otherwise, we can just block until we receive an event. | ||
| #[cfg(feature = "external_printer")] | ||
| if event::poll(EXTERNAL_PRINTER_WAIT)? { | ||
| if !immediately_execute { | ||
| // If the `external_printer` feature is enabled, we need to | ||
| // periodically yield so that external printers get a chance to | ||
| // print. Otherwise, we can just block until we receive an event. | ||
| #[cfg(feature = "external_printer")] | ||
| if event::poll(EXTERNAL_PRINTER_WAIT)? { | ||
| events.push(crossterm::event::read()?); | ||
| } | ||
| #[cfg(not(feature = "external_printer"))] | ||
| events.push(crossterm::event::read()?); | ||
| } | ||
| #[cfg(not(feature = "external_printer"))] | ||
| events.push(crossterm::event::read()?); | ||
|
|
||
| // Receive all events in the queue without blocking. Will stop when | ||
| // a line of input is completed. | ||
| while !completed(&events) && event::poll(Duration::from_millis(0))? { | ||
| events.push(crossterm::event::read()?); | ||
| } | ||
|
|
||
| // If we believe there's text pasting or resizing going on, batch | ||
| // more events at the cost of a slight delay. | ||
| if events.len() > EVENTS_THRESHOLD | ||
| || events.iter().any(|e| matches!(e, Event::Resize(_, _))) | ||
| { | ||
| while !completed(&events) && event::poll(POLL_WAIT)? { | ||
| // a line of input is completed. | ||
| // Receive all events in the queue without blocking. Will stop when | ||
| while !completed(&events) && event::poll(Duration::from_millis(0))? { | ||
| events.push(crossterm::event::read()?); | ||
| } | ||
|
|
||
| // If we believe there's text pasting or resizing going on, batch | ||
| // more events at the cost of a slight delay. | ||
| if events.len() > EVENTS_THRESHOLD | ||
| || events.iter().any(|e| matches!(e, Event::Resize(_, _))) | ||
| { | ||
| while !completed(&events) && event::poll(POLL_WAIT)? { | ||
| events.push(crossterm::event::read()?); | ||
| } | ||
| } |
There was a problem hiding this comment.
could you explain the purpose of these changes? it seems like only the if immediately_execute below all this should be necessary to accomplish the change, but not sure what you had in mind.
There was a problem hiding this comment.
Thanks for the review! Now that I see how github displays the change, I am confused as well. All of this is indentation, except for the if !immediately_execute. I think that github confuses the two instances of events.push(crossterm::event::read()?);.
There was a problem hiding this comment.
The point is that I don't want reedline to read from stdin when it is in immediately_accept mode. So I skip all these conditional/looped input reads and further down add the Submit to the queue.
|
I'm so sorry for missing some of the calls. Now, clippy should pass |
|
Is there anything that could be helped to get this merged? |
|
Ping maintainers? |
|
Well, when I am new to a repo I try to be careful in my interaction as I don't want to annoy the maintainers. Btw: part reason, why I would like to see this getting into the next release is that I recently learned about the |
|
sorry, this one fell off my radar and i've been very busy recently. i will take another look when i get the chance |
Description
Pass a boolean value
immediately_executeto each invocation ofget_line.This way, the nu command
commandline editcan accept a flag--acceptand not only edit the currently, but also immediately execute the result.API
The API severely changes, as now this flag has to be passed to
get_lineandget_line_helper.This could be changed to a channel, but then the initialization of the module would get more complicated.