Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ultimate_extractor to unzip exe files #1075

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Conversation

ViSaturn
Copy link
Contributor

The unzip command can unzip exe files, this reflects that in ultimate_extractor.nu

The unzip command can unzip exe files, this reflects that in `ultimate_extractor.nu`
@fdncred
Copy link
Contributor

fdncred commented Mar 22, 2025

This could be a footgun because it would only extract self-extracting executables because normal executables cannot be extracted. However, I'm willing to move forward since one would think people wouldn't try to extract normal exe's.

@fdncred fdncred merged commit 13de337 into nushell:main Mar 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants