[CS2103-T17-2] CampusBook#21
Open
DJsudartha wants to merge 330 commits into
Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Cheeden
pushed a commit
to Cheeden/tp
that referenced
this pull request
Oct 1, 2025
Add AboutUs by Yati
jooh6969
pushed a commit
to jooh6969/tp
that referenced
this pull request
Oct 2, 2025
Update profile photo
Add favorite
Add Module field
Feature: Add select command to preload faculty contacts
Enhance find command to support faculty and compound searches
Fix bugs for v1.6
…ne number constraint
… as synonym for generic address book
- Update Person.isSamePerson() to check both name and phone number - Update UserGuide to clarify duplicate contact rules - Contacts with same name OR same phone number are considered duplicates - Prevents both duplicate names and duplicate phone numbers
Last minute changes to DG
- Add warning in name field notes about not using command prefixes - Add note in FAQ section about command prefix limitation - Clarifies that prefixes like n/, p/, e/ in names will cause parsing errors - Addresses code review comments about prefix handling
- Update AddCommand error message to specify 'same name or phone number' - Update EditCommand error message to specify 'same name or phone number' - Update DuplicatePersonException javadoc to clarify duplicate criteria - Addresses code review comment about ensuring error messages are updated
- Add test cases in NameTest to verify prefix-like patterns without space are valid at Name level - Add test case in AddCommandParserTest to verify names with prefix (with space) cause parsing errors - Documents that while names with prefix patterns are valid at validation level, they cause issues when used in commands - Addresses code review comment about verifying prefix behavior in names
- Fix line length violations in MESSAGE_DUPLICATE_PERSON constants - Split long lines to comply with 120 character limit
- Remove conditional logic for singular/plural forms in code - Use (s) notation consistently for quantities that may vary (0, 1, or many) - Keep fixed singular/plural forms where quantity is certain (e.g., 'Listed all persons') - Update all test expectations to match new message formats - Update DeveloperGuide.md test case descriptions Changes: - ImportCommand: contact(s), duplicate row(s), invalid row(s) - Messages: person(s) listed, person(s) deleted, person(s) found, field(s) - DeleteCommand: person(s) for batch delete, removed conditional logic - FindCommand: removed conditional, unified to person(s) listed - JsonSerializableAddressBook: duplicate person(s) (variable quantity) - ListCommand: kept 'persons' (certain plural with 'all') - Updated all related test files to match new formats
Fix linking issues in v1.6 UG
- Add back FAQ explaining why same names with different capitalisation are allowed - This aligns with the code behavior where names are case-sensitive - Examples: John & john, McKenzie & Mckenzie can be added if phone numbers differ
PE-D Bug fixing
Update DeveloperGuide.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CampusBook is a centralized app for university students that makes it easy to find and access contact information for professors, staff, and administrative departments, eliminating the need to search across multiple platforms. It streamlines communication within the university, saving students time and effort.