[inzk0518] iP#944
Open
inzk0518 wants to merge 36 commits into
Open
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
-fix wrong directory tracking (src/main/java) and start tracking project root repo
Merge JavaDoc comments
Merge standardized code
Merge find command added
This is to sync the branch in the iP tracker so that it can detects branch-Level-7
Make some change so that the code alligns with the code standard. Also this branch is created to sync the iP tracker to branch-Level-8 purpose.
Add assert in code snippet of parsing mark, unmark and delete command To catch index input smaller than 1 and will be able to terminate the execution earlier.
Critically examines the code and refactor to improve the code quality where necessary To make sure my code follows closely the 'Code Quality' topics
Add Assertion to Parser.parse(String) method
Improve code quality
Add edit command Add edit command which can edit description, deadline time, and event start and end time of existing task This can make editing easier without having to delete and add the task again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FaithPro
FaithPro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features: