[WFYishere] iP#915
Open
WFYishere wants to merge 68 commits into
Open
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
…lete/mark/unmark; handle first-run & corrupted lines
…ss to quokka.Launcher
Adding multiple tasks or printing multiple error lines requires repetitive calls. The API forces callers to loop or chain calls. Varargs simplify call sites while keeping existing calls working. Let's * change `TaskList.add(Task t)` to `add(Task... items)` (null-safe) * change `Ui.showError(String message)` to `showError(String... messages)` * keep backward compatibility so current code compiles unchanged This reduces boilerplate and clarifies intent without widening scope.
Parser methods guarantee the command word contains no spaces and that the remainder is trimmed; these properties were implicit and easy to violate accidentally. Event creation also assumes the start date does not come after the end date. When that assumption is broken, the app behaves unpredictably.
[WFYishere] A-Assertions
…lauses Date parsing/formatting is duplicated across Event and Deadline, which invites divergence and subtle bugs. Storage uses inline delimiters and ad-hoc regexes in multiple places, making the save/load format harder to maintain.
… encounter during usage.
WHAT: Verify MMM d yyyy formatting for a known date. WHY: Guards against unintended formatter changes.
the commit.
WHAT: Replace fully-qualified Dates calls with imported version. WHY: Improves readability; no functional changes.
WHAT: Add Javadoc for containsDuplicate and dupKey. WHY: Makes dedupe criteria explicit for future maintainers.
WHAT: Verify MMM d yyyy formatting for a known date. WHY: Guards against unintended formatter changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.