[yosonteo] iP#663
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
There was a problem hiding this comment.
Might want to consider moving user input handling and tasks function to dedicated classes? Makes main Jone class cleaner and should be very easy with the help of brother Chat.
Sengernest
left a comment
Sengernest
left a comment
There was a problem hiding this comment.
Overall, the code LGTM. Just a few minor nits to address for consistency with the coding standards.
| private static final String DATETIME_FORMAT_ERROR = | ||
| "Invalid datetime format. Please use yyyy-MM-dd HHmm."; | ||
|
|
||
| private final LocalDateTime start; |
There was a problem hiding this comment.
I like that you extracted DATETIME_FORMAT and DATETIME_FORMAT_ERROR into constants which follows the coding standard.
| @@ -0,0 +1,119 @@ | |||
| package jone; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
I like that you have used header comments for each public function and class that follows the conding standard.
| String command = parts[0]; | ||
|
|
||
| try { | ||
| switch (command) { |
There was a problem hiding this comment.
Please adjust your IDE settings to disable the default indentation for switch–case statements so that case labels are not indented. This will ensure the formatting follows the coding standards.
Add assertions in Parser, TaskList, Storage, and Ui
Added a new 'help' command in Jone.java and Ui.java that displays the list of available commands and their usage. This improves usability by making the application more self-explanatory for first-time users. Benefits: - Users no longer need to rely on external documentation - Reduces friction when recalling command syntax - Makes the chatbot more user-friendly and accessible
- Added tests for Todo, Deadline, Event default state - Verified mark/unmark works correctly - Added exception tests for invalid Deadline and Event inputs These tests increase code coverage and ensure robustness against invalid date formats, while confirming that mark and unmark behaviour is consistent across all subclasses
5 participants
No description provided.