[Print2PDF] iP#662
Open
Print2PDF wants to merge 46 commits into
Open
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
WhyXLook
reviewed
Sep 5, 2025
WhyXLook
left a comment
There was a problem hiding this comment.
Looks good overall :)
Some improvements for code quality - naming is suggested
|
|
||
| public static void main(String[] args) { | ||
|
|
||
| Scanner userInput = new Scanner(System.in); |
There was a problem hiding this comment.
I felt that the name userInput for the scanner object was misleading, especially since you have currUserInput in the next line
I would suggest something like inputScanner instead
|
|
||
| String[] parts = input.split(" ", 2); | ||
| String command = parts[0].toLowerCase(); | ||
| String restOfInput = parts.length > 1 ? parts[1] : ""; |
There was a problem hiding this comment.
Perhaps the name ( restOfInput ) could be more descriptive to better explain what it would hold.
For example arguments
| * Getter | ||
| * Return mark status | ||
| */ | ||
| public boolean isItMarked() { |
There was a problem hiding this comment.
I would suggest a more conventional naming for the getter
Something like getIsMarked
|
|
||
| } | ||
|
|
||
| public static Task parseTask(String input) throws SKException { |
Adding Level-9: Find
printbot has assumptions in commands and TaskList.java assert statements added in these classes
Code is not of sufficient quality Code is now more standardised and readable
TaskList.java use for loops replace loops with streams
AddCommand.java and DeleteCommand.java have merge issues Manually edited both files
Follow merge diagram given at CS2103T github
Follow merge diagram at CS2103T github
master not showing latest on github add corrections and commit again
No help page or list enter help calls HelpCommand
\n\n datetime is not read and write correctly \n\n datetime to string conversion is now in parser
\n\n functions botMark, botUnmark, botDelete have repeating code \n\n functions botAdd__ have nested statements \nremove nested statements and abstract out repeated code
UserGuide is previously default Duke description Update README.md to user guide for PrintBot
PrintBot has default duke README.md file Update README.md to PrintBot user guide
PrintBot has simple gui and fixed window Modify MainWindows.fxml to anchored text field, send button and scroll pane Create CSS files and link to FXML for better gui aesthetic
PrintBot use default aesthetic from CS2103T JavaFX tutorial Modify background to black Modify text font Modify dialog box format
PrintBot missing Ui.png Add Ui.png to docs Finalise GUI PrintBot version for release on GitHub
- Missing: Ai usage not correctly shown in ip - Missing: AI.md document missing in ip - New: AI.md with correct AI usage add to ip
Gui image example is currently outdated, representing v0.2 Add Ui.png to README.md document Separate v0.2 and v1.0 gui images to help users differentiate
Missing latest gui image in README.md Missing merge requirement for git standard Update README.md Merge PR into master
Incorrect save and write format for PrintBot Incorrect exception handling display for index out of bounds Incorrect application does not close on exit command Correct save and write format for Deadline and Event tasks Replace exception thrown when index out of bounds Add functionality to close application on exit command Remove unused code Add JavaDocs for more functions
CodeQuality is not up to date Missing several Javadoc comments Incorrect save and read functionality for PrintBot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrintBot 🤖 - Your Personal Task Manager
PrintBot frees your mind of having to remember things you need to do. It's:
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features
Here are some things PrintBot can do:
Add simple tasks with
todoAdd time sensitive tasks with
deadlineSchedule events with
eventDelete tasks with
deleteMark tasks as done with
markMark tasks as not done with
unmarkView all tasks with
listAutomatically save and load your previous tasks
Search for task with
findSee all available commands with
helpSort tasks by urgency (coming soon)
Command Examples
Here are the available commands you can try:
Task Management
View Tasks
Need help?
Sample Interaction
Architecture
If you are a Java programmer, you can use it to practice Java too. Here's the
mainmethod:Curious about our task formats?
We support three types of tasks:
todo <description>todo read bookdeadline <description> /by <due date>deadline return book /by 11/09/2025 17:00event <description> /from <start> /to <end>event meeting /from 24/08/2025 14:00 /to 24/08/2025 16:00Note:
datetimeis indd/MM/yyyy HH:mmformatmark,unmarkanddeleteuse 1-based indexingUse of AI-assisted work
This project has been developed with the assistance of GitHub Copilot to enhance productivity and code quality. All code generated or suggested by these AI tools has been reviewed and modified as necessary to ensure it meets the project's standards and requirements.