[enamourous] iP by enamourous · Pull Request #655 · nus-cs2103-AY2526S1/ip

enamourous · 2025-09-03T15:51:15Z

Note

A task bot built with saves, dates, and search.

Features

Add todos, deadlines, events
Mark/unmark, delete, list
Task list stored in disk automatically
Search with find

Milestones

Level-0: Greet & Exit
Level-4: Todo/Deadline/Event
Level-7: Save to disk
Level-8: Dates (LocalDate)
Level-9: find command
Level-10: GUI version

Task list

Open PR
Finish CA1
Complete iP
Get A in CS2103T

Sample usage

// Add a deadline with ISO date, then search
deadline return book /by 2019-12-02
find book

wangyuanchi

The code is generally clean and good!

wangyuanchi · 2025-09-04T07:49:33Z

+                switch (command) {
+                    case "bye":


I think it would be better to align the switch and case statements to better match the coding guidelines.

Suggested change

switch (command) {

case "bye":

switch (command) {

case "bye":

seokjoon27

Nicely done with coding conventions, all coding standards seems to be well adapted.

seokjoon27 · 2025-09-04T18:30:55Z

@@ -0,0 +1,185 @@
+package ip;


Nice packaging for classes

seokjoon27 · 2025-09-04T18:31:35Z

+/**
+ * The Note class represents a simple command-line task manager chatbot.
+ * Users can add todos, deadlines, and events, mark/unmark tasks as done,
+ * delete tasks, find tasks by keyword, and save/load tasks from a file.
+ */


All methods and classes containing header comments

seokjoon27 · 2025-09-04T18:32:34Z

+ * delete tasks, find tasks by keyword, and save/load tasks from a file.
+ */
+public class Note {
+    private static final String FILE_PATH = "data/duke.txt";


SCREAMING_SNAKE_CASE well used

seokjoon27 · 2025-09-04T18:33:56Z

+ */
 public class Task {
+    protected String description;
+    protected boolean isDone;


camelCase well used

ashmitahaldar

Overall great work! Apart from some small tweaks to adhere to coding standard, your chatbot aligns well with code quality standards with regards to naming 😄

ashmitahaldar · 2025-09-05T03:25:04Z

@@ -0,0 +1 @@
+T | 0 | eat rice


Perhaps you could add this data storage file to the .gitignore file, so that your saved task lists don't get added to the repository on GitHub!

ashmitahaldar · 2025-09-05T03:26:17Z

@@ -0,0 +1,50 @@
+package Note.ui;


Could task classes perhaps be placed in a separate package with a different name? Such as Note.task

ashmitahaldar · 2025-09-05T03:26:49Z

+                switch (command) {
+                    case "bye":


ashmitahaldar · 2025-09-05T03:28:30Z

+            for (Task t : tasks) {
+                String line = "";
+                switch (t.getTypeIcon()) { // use getTypeIcon() instead of getType()
+                    case "T":


It would be great if you could match the indentation of the switch and case staements here to align with the coding standard.

Suggested change

case "T":

switch (t.getTypeIcon()) { // use getTypeIcon() instead of getType()

case "T":

In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.

YSTey0808

Overall well done. Maybe can take note of packages and some code standard. Good job

YSTey0808 · 2025-09-05T17:42:47Z

@@ -0,0 +1,47 @@
+package Note.ui;


I think it would be better to have more packages for your ui part. Maybe can abstract out tasks, then storage so on and so forth.

YSTey0808 · 2025-09-05T17:43:09Z

@@ -0,0 +1,55 @@
+package Note.ui;


Same idea. Abstract to new package.

YSTey0808 · 2025-09-05T17:44:34Z

+                case "bye":
+                    return "Bye! Hope to see you again soon!";
+
+                case "list":


My idea is that would be better to abstract out those command implementation to a new method

YSTey0808 · 2025-09-05T17:45:13Z

@@ -0,0 +1,111 @@
+package Note.ui;


Same idea. Abstract to new package would be better.

YSTey0808 · 2025-09-05T17:45:48Z

+        try (BufferedWriter writer = new BufferedWriter(new FileWriter(filePath))) {
+            for (Task t : tasks) {
+                String line = "";
+                switch (t.getTypeIcon()) { // use getTypeIcon() instead of getType()


Should take note of swtich case code style

YSTey0808 · 2025-09-05T17:46:14Z

@@ -0,0 +1,36 @@
+package Note.ui;


Same idea. Abstract to new package would be better.

YSTey0808 · 2025-09-05T17:46:21Z

@@ -0,0 +1,61 @@
+package Note.ui;


Same idea. Abstract to new package.

The code for parsing dates and extracting command arguments relies on assumptions that are not explicitly documented in the code itself. For example, Deadline.parseDateTime assumes that the input string follows the d/M/yyyy HHmm format, while methods in Parser assume the presence of certain flags or spacing in user input. Without explicit documentation, such assumptions are easy to overlook. This can make debugging harder when unexpected input causes failures in non-obvious places. Let's add Java assert statements in critical places to document these assumptions. Assertions make the expectations clear to both the developer and future maintainers, while also allowing failures to be detected early during testing. Using assert instead of exceptions is appropriate here because: These conditions reflect developer assumptions, not user errors. They act as internal documentation that disappears in production (when assertions are disabled). This improves code clarity, ensures that hidden assumptions are explicit, and strengthens maintainability without affecting runtime behavior for end users.

Add assertions to document parser and deadline assumptions

enamourous added 2 commits September 3, 2025 01:00

Level 1

8d43b1a

Levels 0 to 9

7b6e2b3

wangyuanchi reviewed Sep 4, 2025

View reviewed changes

seokjoon27 reviewed Sep 4, 2025

View reviewed changes

ashmitahaldar reviewed Sep 5, 2025

View reviewed changes

damithc and others added 7 commits September 5, 2025 16:12

build(gradle): add Gradle support

357668c

build(gradle): bump Gradle and library versions

d5e79fa

test: add JUnit Tests

a6e93cf

build(gradle): add Gradle build system

1738998

build(gradle): configure Gradle build

d7c2534

build(javafx): add Gradle configuration for JavaFX

e7722c1

enamourous force-pushed the master branch from 09921cf to e7722c1 Compare September 5, 2025 08:16

enamourous added 3 commits September 5, 2025 19:04

feat(UI): add UI for chatbot

6d0f768

feat(UI): add UI for chatbot

8935561

fix(Level-8): update date/time format

cc6f706

YSTey0808 reviewed Sep 5, 2025

View reviewed changes

enamourous added 6 commits September 13, 2025 01:53

Merge pull request #1 from enamourous/branch-A-Assertions

af7db43

Add assertions to document parser and deadline assumptions

feat(help): add help command

f94846b

build(UG): add user guide

f764ecc

build(UG): add user guide

1b4d416

fix(bye): fix bug when entering bye

e1c74d2

	case "T":
	switch (t.getTypeIcon()) { // use getTypeIcon() instead of getType()
	case "T":

Conversation

enamourous commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note

Features

Milestones

Task list

Sample usage

Uh oh!

wangyuanchi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seokjoon27 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashmitahaldar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YSTey0808 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

enamourous commented Sep 3, 2025 •

edited

Loading