[FZFZFZZ] iP#649
Open
FZFZFZZ wants to merge 40 commits into
Open
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
IsaiahToh
reviewed
Sep 4, 2025
IsaiahToh
left a comment
IsaiahToh
left a comment
There was a problem hiding this comment.
Nice implementation of the task, great job following the coding standard.
| SavedMeta meta = SavedMeta.parse(line); | ||
| Task t; | ||
| switch (meta.type) { | ||
| case 'T' -> t = new ToDoTask(meta.payload); |
There was a problem hiding this comment.
Cool use of lambda styled switch statements, rarely see that.
| } | ||
| return baseString; | ||
| } | ||
|
|
| "event", (input) -> addTask(input, "event"), | ||
| "todo", (input) -> addTask(input, "todo"), | ||
| "delete", (input) -> deleteTask(input) | ||
| ); |
There was a problem hiding this comment.
Smart way of implementing the commands.
| import java.util.ArrayList; | ||
| import java.util.Map; | ||
| import java.util.Scanner; | ||
| import java.util.function.Consumer; |
There was a problem hiding this comment.
Good ordering of package imports, easy to process mentally.
Add assertions for key command methods
Branch a code quality
Branch a streams
A new `help` command is introduced in `CommandManager` to provide users with a quick reference of all supported commands and their usage. This improves usability by letting users discover functionality without checking external documentation. The help output is wrapped with `ui.wrapOutput()` for consistent formatting with other system messages. It lists commands such as `list`, `todo`, `deadline`, `event`, `delete`, `mark`, `unmark`, `find`, and `help` itself, along with a short description of their usage. This change enhances user experience by offering a clear and accessible guide directly in the CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChioChat Launcher
ChioChat Launcher is the entry point for the ChioChat application. It helps you initialize and launch the application seamlessly. It's:
All you need to do is:
Launcherclass.And you're ready to go! 🚀
Features:
If you are a Java programmer, you can use it to practice JavaFX development too. Here's the
mainmethod: