[learningcoding-pixel] iP#648
Open
learningcoding-pixel wants to merge 52 commits into
Open
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
subhitsha-sp
reviewed
Sep 5, 2025
subhitsha-sp
left a comment
subhitsha-sp
left a comment
There was a problem hiding this comment.
LGTM! The naming follows the standard conventions.
| @@ -0,0 +1,18 @@ | |||
| package cat; | |||
|
|
|||
There was a problem hiding this comment.
How about adding javaDoc to your code?
| // Constructor for the exception | ||
| public Exception(String message) { | ||
| super(message); | ||
| } |
There was a problem hiding this comment.
What about implementing more types of exceptions to handle different errors?
uylulu
reviewed
Sep 7, 2025
Comment on lines
+56
to
+77
| }else if(userInput.contains("unmark")) { | ||
| tasks.get(num - 1).setUnDone(); | ||
| printAll(tasks); | ||
| }else if(userInput.contains("mark")) { | ||
| tasks.get(num - 1).setDone(); | ||
| printAll(tasks); | ||
| }else if(userInput.contains("delete")){ | ||
| tasks.remove(num - 1); | ||
| printAll(tasks); | ||
| }else if(userInput.contains("todo")) { | ||
| name = userInput.substring(5); | ||
| Todo todo = new Todo(name); | ||
| tasks.add(todo); | ||
| printAll(tasks); | ||
| }else if(userInput.contains("deadline")) { | ||
| int index = userInput.indexOf('/'); | ||
| name = userInput.substring(9, index); | ||
| String endDate = userInput.substring(index + 1); | ||
| Deadline deadline = new Deadline(name, endDate); | ||
| tasks.add(deadline); | ||
| printAll(tasks); | ||
| } else if(userInput.contains("event")) { |
Comment on lines
+13
to
+38
| /** | ||
| * Creates a new Event task with the given name, start date, and end date. | ||
| * | ||
| * @param name The name or description of the Event task. | ||
| * @param startDate The start date of the event as a string (format as needed for display). | ||
| * @param endDate The end date of the event as a string in the format "d/M/yyyy HHmm". | ||
| */ | ||
| public Event(String name, String startDate, String endDate){ | ||
| super(name,endDate); | ||
| this.startDate = startDate; | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * Returns the status of the Event task as a formatted string. | ||
| * Format: [E][status] name (Start: startDate) (End: endDate) | ||
| * Example: [E][X] Meeting (Start: 01/09/2025 1400) (End: 01/09/2025 1600) | ||
| * | ||
| * @return A string representing the task's completion status along with start and end dates. | ||
| */ | ||
| @Override | ||
| public String getStatus(){ | ||
| String stat= isDone ? "[X]" : "[ ]"; | ||
| return "[E]" + stat + " " + name + " " + "(Start: " + startDate + ") " + "(End:" + endDate + ")" ; | ||
| } | ||
|
|
There was a problem hiding this comment.
I like how easy it is to understand your java doc
Comment on lines
+3
to
+4
| import java.io.*; | ||
| import java.util.*; |
There was a problem hiding this comment.
Maybe it is better to import only what you need.
There was a problem hiding this comment.
LGTM – perhaps you can add this file to your .gitignore
Implement assert feature
Branch a code quality
Branch a streams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.