[0rbita1] iP#645
Open
0rbita1 wants to merge 41 commits into
Open
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
Merge add-gradle-support to use gradle
watermelonisred
left a comment
watermelonisred
left a comment
There was a problem hiding this comment.
overall, i find your class and method names very easy to understand, and your code looks good to me in terms of naming conventions!
Comment on lines
+10
to
+12
| final static int TASK_CODE_INDEX = 1; | ||
| final static int MARKED_STATUS_INDEX = 4; | ||
| final static int SUBSTRING_START_INDEX = 7; |
| * @param date The `LocalDateTime` object representing the deadline. | ||
| * @param tasks The `ArrayList` to which the new deadline task will be added. | ||
| */ | ||
| public static void loadDeadline(String description, Boolean isDone, LocalDateTime date, ArrayList<Task> tasks) { |
There was a problem hiding this comment.
perhaps you could update the parameter 'date' to 'datetime' to make it clearer that it has both date and time?
| ArrayList<String> saveContents = Storage.retrieveSaveContents(); | ||
|
|
||
| for (int i = 0; i < saveContents.size(); i++) { | ||
| String saveContent = saveContents.get(i); |
There was a problem hiding this comment.
personally "saveContent" sounds more like a verb to me, but its not a big deal
| public Ui() { | ||
| } | ||
|
|
||
| public static void printSuccessfulTaskAddition(ArrayList<Task> taskList) { |
isaactoh
reviewed
Sep 5, 2025
| } | ||
|
|
||
| public static void printSuccessfulTaskAddition(ArrayList<Task> taskList) { | ||
| addMessageToBuffer("Task successfully added:\n" + taskList.get(taskList.size() - 1) + "\n" + "Task counter: " + |
There was a problem hiding this comment.
Is it possible to distribute the characters across both lines more evenly so the top line doesn't cross the soft character limit?
| * @param isDone A boolean indicating whether the task is marked as done. | ||
| * @param tasks The ArrayList to which the loaded task will be added. | ||
| */ | ||
| public static void interpretAndLoadDeadlineSave(String taskContent, Boolean isDone, ArrayList<Task> tasks) { |
There was a problem hiding this comment.
Would a less lengthy name, say interpretSavedDeadline be clearer?
- Modified input interpreter to accept update command. - Update command as follows: "update <<task index number>> <<task field>> <<new value>>". - Added new functions in parser to accomodate update command functionality.
- Added assertions to all methods in Storage and TaskList - Assertions involved checking if each parameter is null - Assertions include assertion messages
- Broke up update methods into smaller components - Reduced nested logic
Modify update parsing methods to follow code quality standards
Merging as the current un-merged branch is no longer in sync with the latest master
Add assertions to Storage and TaskList files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0rbita1
It is
difficulteasy to chat toYou can start by
public class Main { public static void main(String[] args) { Application.launch(MainApp.class, args); } }Updated the
calculateTotalfunction to handle null values and modified theuser.emailvalidation.Features:
Forked from this project
Hope you enjoy 😀