lanjia0 iP#642
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
dingf3ng
left a comment
dingf3ng
left a comment
There was a problem hiding this comment.
Looks promising as a project at early stage! Some OOP patterns are observed. Maybe need more time to do further development and polishing work :)
| System.out.println("Eh! I'm Soon Tong\nWhat you want?!"); | ||
|
|
||
| // init array of Tasks | ||
| Task[] list = new Task[100]; |
There was a problem hiding this comment.
It seems better to use Collections (ArrayList for example) to store the task :).
|
|
||
| String curr = sc.nextLine(); | ||
| String[] words = curr.split(" "); // split by spaces | ||
| String firstWord = words[0]; // take the first word |
There was a problem hiding this comment.
camelCase variable name very good yay
| } | ||
|
|
||
| // unmarks task, task is not done | ||
| public void markUndone() { |
There was a problem hiding this comment.
name representing methods are verbs! v good
| @@ -0,0 +1,25 @@ | |||
| public class Task { | |||
| private boolean isDone; | |||
There was a problem hiding this comment.
camelCase and sounds like boolean! good job
| System.out.println("Eh! I'm Soon Tong\nWhat you want?!"); | ||
|
|
||
| // init array of Tasks | ||
| Task[] list = new Task[100]; |
There was a problem hiding this comment.
name sounds like a collection of objects! good!
TheresiaOng
left a comment
TheresiaOng
left a comment
There was a problem hiding this comment.
Keep up the good work on your iP progress! There are only minor adjustment you need to make (e.g. indentation fix) but overall this is a great foundation to build your iP on! Good job! ^^
|
|
||
| Storage storage = new Storage("./data/tasks.txt"); | ||
| Task[] list = new Task[100]; | ||
| boolean running = true; |
There was a problem hiding this comment.
boolean variable name could be improved to isRunning to improve readability ^^
| while (running) { | ||
|
|
||
| String curr = sc.nextLine(); | ||
| String[] words = curr.split(" "); // split by spaces |
There was a problem hiding this comment.
Great usage of plural variable name to represent a collection of item (words)!
|
|
||
| Task task; | ||
| switch (type) { | ||
| case "T": |
There was a problem hiding this comment.
Switch cases should be at the same indentation as the switch declaration ^^
| // write to file format | ||
|
|
||
| @Override | ||
| public String toFileFormat() { |
There was a problem hiding this comment.
great usage of camelCase and verb as your method name!
use assertions to make sure important assumptions hold at various points in code * assertions in Storage class ensure a filepath is provided on initialization * assertions in TaskList ensure all accessed elements within bounds * assertions in TaskDecoder ensure saved tasks are valid before writing
removing unecessary syntax and abstracting functions to substitute duplicate code occurances makes code neater and more readable Let's: * delete unused import statements * abstract function that mutate task list and saves right after
add assertions
improve code quality
tag existing tasks in task list with additional descriptive words (e.g. #fun) to provide more information about task
fix issues in TaskDecoder class and comment out redundant CLI methods in AngSoonTong class GUI load from storage file fixed
to create a more unique AngSoonTong personality, add more authentic images for use as profile photo
allow users to remove individual tags that they have added, or remove all tags - for a specified task
chatbot "sings" a song when the input sing is given by the user
sing function will randomly choose one song to play from songs list
JUNIT test case already covered by Assertions in TaskList class
for thorough testing of methods in Parser and TaskList classes Let's: * add comments to explain which methods are being tested
…'s subclasses Let's: * add comments to classes and methods to describe their what, why
Let's: * add comments to classes and methods to describe their what, why
Let's: * add comments to classes and methods to describe their what, why
fix a mistake under the mark feature, where the returned output was incorrect
Add changes made on github website merge to include changes directly made to remote repo
add screenshot of ui to showcase what the chatbot looks like
remove comments and annotations accidentally left in the README.md
6 participants
Ang Soon Tong Chatbot
Soon Tong is your friendly neighbourhood ah beng, he can help you:
politelyHere's 3 fun facts about Soon Tong
His hobbies