Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W5.11r][W10-B2]Ma Yuqian #771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[W5.11r][W10-B2]Ma Yuqian #771

wants to merge 1 commit into from

Conversation

XavierMaYuqian
Copy link

No description provided.

@nus-se-pr-bot nus-se-pr-bot assigned okkhoy and hwkchia and unassigned okkhoy Mar 8, 2018
okkhoy
okkhoy reviewed Mar 11, 2018
View reviewed changes
Copy link

@okkhoy okkhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this. I didn't find any glaring coding standard violations 👍
Also good to see you have updated both documentation and tests.

@okkhoy
Copy link

okkhoy commented Mar 11, 2018

@XavierMaYuqian
Some comments added. Please ack & close the PR after reading comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okkhoy okkhoy okkhoy left review comments

Assignees

@okkhoy okkhoy

@hwkchia hwkchia

Labels
Reviewed team.B2 tutorial.W10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XavierMaYuqian @okkhoy @hwkchia @nus-se-pr-bot