Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcode to add a resized image of the NumPy comic #834

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

MarsBarLee
Copy link
Contributor

@MarsBarLee MarsBarLee commented Feb 10, 2025

Brief description of what is fixed or changed

Hi all,
#795 already adds a link to the NumPy comic in the Contribute page.

I want to add a version that add an image of the comic. While I could add the image directly with #795, there is no way to easily resize the image across a variety of browser sizes and devices.

This shortcode adds a comic.html so that CSS can automatically resize the image. This format is used elsewhere in the NumPy

Alternative implementation

There is also an option to embed a flippable version of the comic directly on the Contribute page. This is how Heyzine (the flipbook host) provides their embed option through the iframe tag.

<iframe allowfullscreen="allowfullscreen" scrolling="no" class="fp-iframe" style="border: 1px solid lightgray; width: 100%; height: 400px;" src="<https://heyzine.com/flip-book/3e66a13901.html>"></iframe>

I haven't tested out yet if NumPy website works nice with iframe.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for numpy-org failed.

Name Link
🔨 Latest commit 54dc5a7
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/67aa62c5cd5a85000845421a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant