Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the numpy installation page with tab based navigation #832

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Musharraffaijaz
Copy link
Contributor

image

Copy link

netlify bot commented Feb 8, 2025

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 1ec6b0c
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/67b4b66cf25b810008cbf7e4
😎 Deploy Preview https://deploy-preview-832--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Musharraffaijaz
Copy link
Contributor Author

This PR tries to resolve the issue DOC: update installation page #811

@Musharraffaijaz
Copy link
Contributor Author

@melissawm @lucascolley could you please review this?

@mattip
Copy link
Member

mattip commented Feb 18, 2025

When I look at the installation page from this PR I get confused. The page opens with a section on conda and pip, and then there are three tabs with the titles "Recommended method", "Python Package Management", and "NumPy Packages and Libraries". The meaing of those titles is not clear, and the pip/conda directions are repeated.

The layout on the Scipy page is much better. Could you copy that page to here and replace scipy with numpy?

@Musharraffaijaz
Copy link
Contributor Author

Musharraffaijaz commented Feb 18, 2025

When I look at the installation page from this PR I get confused. The page opens with a section on conda and pip, and then there are three tabs with the titles "Recommended method", "Python Package Management", and "NumPy Packages and Libraries". The meaing of those titles is not clear, and the pip/conda directions are repeated.

The layout on the Scipy page is much better. Could you copy that page to here and replace scipy with numpy?

Thank you for your review and reply, I have a small question, what about the installation steps? Since they are all different? So do you just want the scipy initial para to be the similar, and trhe rest of the steps to be as it is?
image

@mattip
Copy link
Member

mattip commented Feb 18, 2025

Since they are all different?

The installation instructions for NumPy and Scipy should be the 95% the same, other than some small details. Where are they different?

@Musharraffaijaz
Copy link
Contributor Author

Since they are all different?

The installation instructions for NumPy and Scipy should be the 95% the same, other than some small details. Where are they different?

No I mean in scipy we have install via pixpi, uv those steps are different I think? SO you want whole the numpy/install page to be similiar to scipy with the name scipy changed to numpy?

@melissawm
Copy link
Member

The NumPy installation should be simpler, but yes the page needs a full rewrite I'm afraid. You should verify that those steps work for NumPy as well, and there are a few that are only necessary for SciPy.

@Musharraffaijaz
Copy link
Contributor Author

@melissawm @mattip thank you for your suggestions, could you please check the latest commits? I have tried something different have checked and verified different installation methods accros internet and through GPT as well. Could you please review this and suggest changes. Thanks

Copy link
Member

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thanks. Just a small nit.

Comment on lines +24 to +27
NumPy can be installed with a `package manager` on
macOS and Linux, or [from source](https://numpy.org/devdocs/building).
For more detailed instructions, consult our **Python and NumPy
installation** guide below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these lines can be removed.

Suggested change
NumPy can be installed with a `package manager` on
macOS and Linux, or [from source](https://numpy.org/devdocs/building).
For more detailed instructions, consult our **Python and NumPy
installation** guide below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants