-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the numpy installation page with tab based navigation #832
base: main
Are you sure you want to change the base?
update the numpy installation page with tab based navigation #832
Conversation
Musharraffaijaz
commented
Feb 8, 2025
…page with tab based navigation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This PR tries to resolve the issue DOC: update installation page #811 |
@melissawm @lucascolley could you please review this? |
When I look at the installation page from this PR I get confused. The page opens with a section on conda and pip, and then there are three tabs with the titles "Recommended method", "Python Package Management", and "NumPy Packages and Libraries". The meaing of those titles is not clear, and the pip/conda directions are repeated. The layout on the Scipy page is much better. Could you copy that page to here and replace |
Thank you for your review and reply, I have a small question, what about the installation steps? Since they are all different? So do you just want the scipy initial para to be the similar, and trhe rest of the steps to be as it is? |
The installation instructions for NumPy and Scipy should be the 95% the same, other than some small details. Where are they different? |
No I mean in scipy we have install via pixpi, uv those steps are different I think? SO you want whole the numpy/install page to be similiar to scipy with the name scipy changed to numpy? |
The NumPy installation should be simpler, but yes the page needs a full rewrite I'm afraid. You should verify that those steps work for NumPy as well, and there are a few that are only necessary for SciPy. |
@melissawm @mattip thank you for your suggestions, could you please check the latest commits? I have tried something different have checked and verified different installation methods accros internet and through GPT as well. Could you please review this and suggest changes. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thanks. Just a small nit.
NumPy can be installed with a `package manager` on | ||
macOS and Linux, or [from source](https://numpy.org/devdocs/building). | ||
For more detailed instructions, consult our **Python and NumPy | ||
installation** guide below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these lines can be removed.
NumPy can be installed with a `package manager` on | |
macOS and Linux, or [from source](https://numpy.org/devdocs/building). | |
For more detailed instructions, consult our **Python and NumPy | |
installation** guide below. |