Skip to content

Replace icons in Scientific Domains tab #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 5, 2021

Conversation

MarsBarLee
Copy link
Contributor

@MarsBarLee MarsBarLee commented Feb 17, 2021

Resolves gh-369

Removed Interactive Computing, Simulation Modeling and Multi-variate Analysis. Added Chemistry, Geoscience and Robotics.

Preview:

Untitled

Right now I've left the projects under the new categories Geoscience and Robotics blank since discussion about this is continuing in gh-313.

@MarsBarLee
Copy link
Contributor Author

@InessaPawson The color of the SVGs is black, hex code #00000. In the .svg files, it's stroke="#000". Does that specify the color profile (sRGB)?

@InessaPawson InessaPawson self-requested a review February 22, 2021 02:40
@InessaPawson
Copy link
Member

@MarsBarLee It looks much better now. I have only two suggestions:

  1. The outer angles on the Math Analysis icon look cut off. Consider matching them to the icons for Robotics and Quantum Computing.
  2. Consider matching the stroke width in the Graphs and Networks icon to the rest of the set.

@InessaPawson
Copy link
Member

@InessaPawson The color of the SVGs is black, hex code #00000. In the .svg files, it's stroke="#000". Does that specify the color profile (sRGB)?

@MarsBarLee It would be better if you specify the color profile as follows:
stroke=“rgb(0,0,0)”

Thank you for taking care of it!

@MarsBarLee
Copy link
Contributor Author

Here are the updated icons:
image

@InessaPawson
For specifying the color space to sRGB, I was able to some SVGs from fill:"#0" to fill:"rgb(0,0,0)".

However, other ones such as 'bioinformatics.svg' don't have a fill or stroke property with any color value. It just lists the path location, such as "<path d="M4,2H6V4C6,5.44..." I think it's defaulting the color to black.

I'm looking at W3's color property, so maybe I could add that property to explicitly define the color space? I can't find much examples online of that yet, seems like if the color isn't specified in the SVG, then the person is defining the color in CSS.

@InessaPawson
Copy link
Member

Here are the updated icons:

@MarsBarLee Great job on the latest changes to the icon set!

For specifying the color space to sRGB, I was able to some SVGs from fill:"#0" to fill:"rgb(0,0,0)".

However, other ones such as 'bioinformatics.svg' don't have a fill or stroke property with any color value. It just lists the path location, such as "<path d="M4,2H6V4C6,5.44..." I think it's defaulting the color to black.

Yes, under the current defaults, all SVGs are rgb(0,0,0).

I'm looking at W3's color property, so maybe I could add that property to explicitly define the color space? I can't find much examples online of that yet, seems like if the color isn't specified in the SVG, then the person is defining the color in CSS.

Indeed, most SVGs you'll find around the web use inline CSS, but there are some disadvantages associated with it. For example, you can’t always migrate a CSS file with an SVG, even if you know you should. For that reason alone, relying on CSS isn’t a good strategy for color management. Explicitly defining the color space and color in the SVG file is better in the long run.

@InessaPawson
Copy link
Member

@MarsBarLee My last suggestion for the icon set would be checking the width of the Signal Processing icon. It looks slightly wider than the rest of them.

@MarsBarLee
Copy link
Contributor Author

@InessaPawson I've adjusted the width of the Signal Processing icon and added the color space for the SVGs.

For defining the color space, I added style="stroke:rgb(0,0,0)" to individual SVG paths. However, some icons had multiple paths, so I had to add style="stroke:rgb(0,0,0)" manually multiple times. I'm saw that I could group with the < g > tag so that multiple paths under the group can be defined group at once. I didn't add the < g > tag because I didn't want to change the files too much yet.

I'm working on a NumPy Docs graphics style + best practices guide so I might recommend the < g > tag or suggest people set their color space to RGB in graphic editors like Inkscape.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @MarsBarLee! And thanks for the reviews @InessaPawson!

I added new entries to resolve all the open request for adding more packages to some categories. In it goes.

@rgommers rgommers merged commit c57df4f into numpy:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace icons in Scientific Domains tab
3 participants