FEAT: radians and deg2rad ufunc implementation
#187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both ufunc equivalent |
juntyr
reviewed
Oct 17, 2025
| quad_radians(const Sleef_quad *op) | ||
| { | ||
| // radians = degrees * π / 180 | ||
| static const Sleef_quad one_eighty = Sleef_strtoq("180.0", NULL); |
There was a problem hiding this comment.
Why are we using string parsing here?
There was a problem hiding this comment.
Easy and accurate, sometimes conversion from int or float gives precision errors (although here it shouldn't technically)
We can also go with qutil, but it seems overkill
|
Taking this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request adds support for converting degrees to radians for quad-precision types by implementing the
radiansanddeg2raduniversal functions (ufuncs) in the codebase. It includes both the implementation of these functions for quad and long double types, their registration with NumPy, updates to the release tracker, and comprehensive tests to ensure correctness.New ufunc implementations and registration
quad_radiansandld_radiansfunctions to compute radians from degrees for quad-precision (Sleef_quad) and long double types, respectively, inops.hpp. [1] [2]radiansanddeg2radufuncs in the NumPy interface initialization, making them available as universal functions for quad-precision arrays.Documentation and tracking
release_tracker.mdto markradiansanddeg2radas implemented and tested for quad-precision.Testing
radiansanddeg2radufuncs, covering a variety of input cases including standard angles, negative values, infinities, NaNs, and edge cases.